fix testJVectorKnnIndex_simpleCase - #692
Merged
Merged
Conversation
added 2 commits
August 18, 2026 14:46
Signed-off-by: ergun-kezer <ergun.kezer@ibm.com>
Signed-off-by: ergun-kezer <ergun.kezer@ibm.com>
ergunkezer1
requested review from
MedhaSrivatsa,
akash-shankaran,
jimdickinson,
reta,
sam-herman and
sandoichi
as code owners
August 18, 2026 12:53
reta
approved these changes
Aug 18, 2026
reta
left a comment
reta
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot @ergunkezer1 !
Contributor
|
The backport to |
reta
pushed a commit
that referenced
this pull request
Aug 18, 2026
* chore: fix flaky testJVectorKnnIndex_simpleCase test * doc: update changelog --------- (cherry picked from commit 65c0eef) Signed-off-by: ergun-kezer <ergun.kezer@ibm.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Ergün Kezer <ergkezer@gmail.com> Co-authored-by: ergun-kezer <ergun.kezer@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem was when
totalNumberOfDocs / maxDochas remainder old solution was working fine. However, when there is no remainder adding +1 was causing error. For example, 2 doc and 10 maxDoc.Related Issues
Resolves #304
Check List
--signoff.Testing
./gradlew test --tests KNNJVectorTests.testJVectorKnnIndex_simpleCase -Dtests.iters=7000By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.